Reviewed as part of the 15-PR edit-panel redesign stack. Full stack review posted on #2120. No blockers on this PR. — Miga

Final current-head pass: d10ce38. Reviewed the stack boundaries and current diff against the flat-inspector contracts; required checks have no failures/pending checks and no unresolved review threads remain. No new drift found; residual notes are non-blocking.

Superseding earlier approval: the latest max-review pass found confirmed correctness issues in this flat-inspector stack (identity/selector-index state, hide-all write races, timing inference, slider pointer/keyboard/reset semantics, and duplicate React keys). Hold merge and require fixes plus re-review on the current stack head.

Re-reviewed exact head 6d0f7553c5ecda6c9a37d7ad60d8b364abc3a886. The throttled draft layer still has two direct races:

• propertyPanelFlatPrimitives.tsx:262-265 blindly copies every parent value echo into local draft state, including while dragging, so a throttled intermediate commit can snap a newer pointer position backward.
• Reset invokes onReset without cancelling the pending throttle/timer at :293-305,375-387; a delayed commit can overwrite the reset after the user sees it apply.

Gate prop-to-draft synchronization while actively dragging and cancel/flush the correct pending work before reset. Add fake-timer tests for mid-drag echoes and reset with a queued commit.

Verdict: REQUEST CHANGES
Reasoning: Throttled prop echoes can snap the control backward and a queued commit can overwrite reset.

— Deepwork

Additive adversarial re-review at exact head . The previously reported prop-echo snapback and reset-vs-queued-commit races remain unchanged.\n\nStrength: The throttle correctly uses a leading commit plus a bounded trailing timer and deduplicates pointer-up against the last sent value ().\n\n**[blocker] A trailing slider callback can revert an intervening Grade edit.** The timer invokes the render-time closure (). Grade handlers spread the render-time whole object before replacing one field (). Queue Exposure, then change Contrast, apply a preset, or reset before 40 ms: the old Exposure callback commits its stale whole-object snapshot and silently undoes the newer action. Use latest-state/functional mutations or cancel/flush pending slider work at conflicting Grade actions; add a fake-timer cross-control regression.\n\n**[blocker] A rejected persist cannot restore the slider draft when the controlled value never changed.** The primitive owns and only resynchronizes when scalar changes (), while is fire-and-forget (). If persistence rejects and the parent value remains the original scalar, the effect does not rerun, leaving the knob and ARIA value at the failed attempted value while the document rolled back. The primitive needs an acknowledged revision/failure reset contract and a rejected-commit test.\n\n**[important] Unmount cleanup drops the latest queued edit.** Cleanup clears the timer without flushing (). Selection/accordion changes during a drag can discard the newest pointer value.\n\nVerdict: REQUEST CHANGES\nReasoning: The unchanged head still has the earlier slider races and adds cross-control stale-snapshot loss plus a visible rollback divergence on failed persistence.\n\n— Deepwork

Additive adversarial re-review at exact head 6d0f7553c5ecda6c9a37d7ad60d8b364abc3a886. The prior prop-echo snapback and reset-versus-queued-commit races remain unchanged.

Strength: The throttle uses a leading commit plus bounded trailing timer and deduplicates release (propertyPanelFlatPrimitives.tsx:245-305).

[blocker] A trailing slider callback can revert an intervening Grade edit. The timer invokes the render-time onCommit closure (propertyPanelFlatPrimitives.tsx:293-305), while Grade handlers spread the render-time whole grading object (propertyPanelFlatColorGradingSection.tsx:401-428). Queue Exposure, then change Contrast, apply a preset, or reset before 40 ms: the old callback commits its stale whole-object snapshot and undoes the newer action. Use latest-state mutations or cancel or flush pending work at conflicting actions; add a fake-timer cross-control test.

[blocker] A rejected persist cannot restore the slider draft when the controlled value never changed. draft only resynchronizes when scalar value changes (propertyPanelFlatPrimitives.tsx:251-265), while onCommit is fire-and-forget (:281-291). If persistence rejects and the parent value remains original, the effect does not run, leaving the knob and ARIA value at the failed value. Add an acknowledged revision or failure-reset contract and rejected-commit test.

[important] Unmount cleanup drops the latest queued edit. It clears the timer without flushing pendingRef.current (propertyPanelFlatPrimitives.tsx:266-270).

Verdict: REQUEST CHANGES
Reasoning: The unchanged head retains earlier slider races and adds stale cross-control loss plus visible rollback divergence on failed persistence.

— Deepwork

Re-reviewed at 98a23fe7b341610d7598b38735f60d9d5c335776.

Both incremental commits are byte-equivalent to the previously reviewed head (patch-id 553da8c5…). propertyPanelFlatPrimitives.tsx:251-342 still overwrites drag-local state on controlled prop echoes, clears rather than flushes pending work on unmount, and leaves reset/trailing callback races. Grade callers still close over whole-object render snapshots, so a queued slider commit can revert an intervening sibling edit. A rejected persist can also leave the draft at the attempted value when the controlled value never changes.

No requested fake-timer, rejected-persist, or unmount regression test was added.

Verdict: REQUEST CHANGES
Reasoning: The force-push is patch-equivalent; the stale-snapshot, rollback, reset, and dropped-pending correctness blockers all remain.

— Deepwork